I don't know why but I'm still having problems getting the range AOb speed etc. Once I have a basic solution I fire but most of the time the fishes miss the target. A big problem I'm having is with the pk. It always has a different range than what the wship model shows on the map. I use the stadometer and put the image to the top of the masts of the real image. So I'm doing it correctly, but the white X is never in the correct place. I'm trying my best to fix this but can't figure it out?

Well, have a visit to my Subsim Sub Skipper's Bag of Tricks thread in my signature and forget all about how nasty that @#$# stadimeter is! You'll be a certified killer in about an hour, guaranteed.

Your problem is obviously the range, since your pk and map differs. Are you sure you have identified the target correctly? Are you running any mods? It's not always correct to put the image to the top of the masts. If you are running SCAF, the correct target range aiming point is marked with red in the recognition manual. The AOB estimation (if not extreme) is often enough to just make a rough "eye estimation". What is "the white X"?

Depending on which mods you use..
I made this mod which corrects the scope apeture optics.
It's a bit out of date, but if you read the PDF files... you'll get the idea.

I'm not using any mods, and still I'm missing. Mainly the angle of how far to lead the target. Also the white X i'm talking about is the pk marker on the attack map. it's where you estimate the target to be. But mine never overlaps the shape of the vessel on the map. Whcih means range AOB speed or bearing one of those is off. And I can't figure out which.

Ok I will try this again, although the last time I got told 'ohh thats too complicated.' Bleh. Do what I do, cause I don't miss.

#1 Range doesn't matter if you have the lead angle figured properly. Rule of thumb, one degree of lead for any ship up to ten knots or so. Warships in TF's I give 1.5 degrees per kt.
#2 AOB is either 80 or 110, depending on which side your target is approaching from. Its always 80 or 110. Why? Because you ALWAYS approach at 90 deg off the targets track.
#3 Get CLOSE! I mean close enough you can smell their rice cooking. 400 yards is good, no more than 800. It is very hard to miss from this range. Shoot between the masts or turrets. This gives you fudge factor.
#4 Forget that stupid PK, there is a precise way you have to use it, and I dont even know what it is. Never used it, dont need it.
#5 Forget the stupid stadimeter, you don't need it either.
#6 Do what RR said and watch those vids because all the above I distilled from them.

Once you have these principles down and you get some experience with them, not only will you almost never miss, you will find yourself able to make shots at multiple targets, and from greater range. Good hunting.

For me it's not too confusing. But the thing I don't understand it how to shoot without range aob etc, and just shoot and fire the torpedoes visually?

Ok try this. Go to the submarine school. Select the 3 rd mission which is torpedo training.

Once the mission is loaded, don't move.
Raise scope.
Immediately set torps to fast speed and open doors 1-4
Now if you look in the scope to the left you have a cruiser approaching you from that way.
Set your AOB to 80 deg starboard. Click to send TWICE! Forget what I said about 100. Always 80.
Set the speed to 9 knots, send it twice.
Now on your range and bearing you can see a little plastic triangle thats used to set range. Pull it clockwise as far as it will go, which is about the 3:30 position.
Move your periscope back to the 350 deg position. Press the send button TWICE.
Your TDC dials should look thus:
The top one (which represents your target) will have a white arrow stabbing it in the right side at a 90 deg angle.
The bottom dial (which is you) has an arrow coming straight out of the nose.
The general relationship of the target dial ship outline is it is crossing your nose left to right.
Now just leave your scope at 350 deg and wait for the target. Once the first turret crosses the cross hairs start firing. I use 5 second intervals.
By the way Im using FOTRS and not stock, the cruiser may come from the other way, I cant remember.
But you should have just hit 4 for 4 without knowing the range, or the ship id. You didn't use the PK or the stad. And, you did it from over 1200 yards away.

SIMPLE!!!!!!!!! AMBUSH using the DOK Method. Look it up in the help section. Intercept your targets course. Use the compass to find a good 90 degree angle. Figure out the direction the target will pass in front of your scope (left or right). Place the PS either +/- 10 mils from the intersection point. Place an X using the pencil on the bow of the target. wait 3 minutes and place another X on the bow . Mesaure the differnce using the ruler. Drop the zero's that's your target speed. Input speed, drag the triangle on range scale all the way to the right, set direction of travel of the enemy ship as it will pass in your PS(does not have to be accurate). Double click on the red triangle(TWICE)and wait. As the target enters the PS fire once it passes your +/- 10 mil point. BANG!!!!!!!!!!!!!!!!!